Date
1 - 18 of 18
Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry
|
Hi all, Now it is official: Sound Splitter 22.02 is ready for public preview, and I would like to request a review before I post a pull request to add-on files repository. Description: Sound Splitter allows you to listen to audio from NVDA and other programs on different audio channels. For example, you can hear NVDA on the right speaker while music comes from the left speaker. This is useful when participating in meetings via apps such as Zoom. IMPORTANT: Sound Splitter was split from Tony Malykh’s Tony’s Enhancements by Joseph Lee (with Tony’s blessing). At this time version 22.02 is the one and only planned release of this add-on as I (Joseph Lee) plan to hand the add-on to the community for further maintenance once the add-on is published to community add-ons website (life priorities). When enhancing this add-on, please give credit to Tony as sound splitter was originally part of his add-on and keep the copyright header please. Repository: https://github.com/josephsl/soundSplitter Version 22.02 download link: https://github.com/josephsl/soundSplitter/releases/download/22.02/soundSplitter-22.02.nvda-addon NVDA compatibility: 2019.3 and later Add-on files key: soundsplitter
Thanks. Cheers, Joseph |
|
|
|
Hi, Note that even though 22.02 is the one and only planned release, I may come back to updating it once NVDA 2022.1 beta 1 is released. Cheers, Joseph
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Joseph Lee via groups.io
Sent: Friday, January 28, 2022 12:08 AM To: nvda-addons@nvda-addons.groups.io Subject: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry
Hi all, Now it is official: Sound Splitter 22.02 is ready for public preview, and I would like to request a review before I post a pull request to add-on files repository. Description: Sound Splitter allows you to listen to audio from NVDA and other programs on different audio channels. For example, you can hear NVDA on the right speaker while music comes from the left speaker. This is useful when participating in meetings via apps such as Zoom. IMPORTANT: Sound Splitter was split from Tony Malykh’s Tony’s Enhancements by Joseph Lee (with Tony’s blessing). At this time version 22.02 is the one and only planned release of this add-on as I (Joseph Lee) plan to hand the add-on to the community for further maintenance once the add-on is published to community add-ons website (life priorities). When enhancing this add-on, please give credit to Tony as sound splitter was originally part of his add-on and keep the copyright header please. Repository: https://github.com/josephsl/soundSplitter Version 22.02 download link: https://github.com/josephsl/soundSplitter/releases/download/22.02/soundSplitter-22.02.nvda-addon NVDA compatibility: 2019.3 and later Add-on files key: soundsplitter
Thanks. Cheers, Joseph |
|
|
|
Noelia Ruiz
Hello, I advice you, when possible, to send relevant info in a unique
toggle quoted message
Show quoted text
message for beter following of threads. Cheers 2022-01-28 9:09 GMT+01:00, Joseph Lee <joseph.lee22590@...>: Hi, |
|
|
|
Hi,
toggle quoted message
Show quoted text
This was separated from an earlier thread because 22.0 was strictly a dev snapshot while 22.02 is the official release. All the relevant info is part of the first message of this thread. Hope this clarifies things unless if I misunderstood you. Cheers, Joseph -----Original Message-----
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Noelia Ruiz Sent: Friday, January 28, 2022 12:13 AM To: nvda-addons@nvda-addons.groups.io Subject: Re: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry Hello, I advice you, when possible, to send relevant info in a unique message for beter following of threads. Cheers 2022-01-28 9:09 GMT+01:00, Joseph Lee <joseph.lee22590@...>: Hi, |
|
|
|
Noelia Ruiz
For example, you may have sent a unique message with relevant info.
toggle quoted message
Show quoted text
This is my suggestion. I'm working on other things related to NVDA, but hope this can be reviewed before you send it to addonFiles. 2022-01-28 9:16 GMT+01:00, Joseph Lee <joseph.lee22590@...>: Hi, |
|
|
|
Hi,
toggle quoted message
Show quoted text
Take time - I don't expect it won't be reviewed immediately as folks are busy. Cheers, Joseph -----Original Message-----
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Noelia Ruiz Sent: Friday, January 28, 2022 12:19 AM To: nvda-addons@nvda-addons.groups.io Subject: Re: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry For example, you may have sent a unique message with relevant info. This is my suggestion. I'm working on other things related to NVDA, but hope this can be reviewed before you send it to addonFiles. 2022-01-28 9:16 GMT+01:00, Joseph Lee <joseph.lee22590@...>: Hi, |
|
|
|
Hello,
Trying to expand my knowledge in add-on reviews. Since I'm a beginner in review process, didn't experiment with that much; Hope to test this more later today. After taking a quick look, I found one typo in Readme: Under the heading of "Sound Splitter settings", it's written "S;litter" instead of "Splitter". I may come with more review comments later. Note: I'm not very familiar with how flake8 exactly works, so I'm not sure if I can test this part deeply, but I think that's not necessary as I don't see all add-ons are using this parsing tool... Thanks. Best regards, Paulius |
|
|
|
Hi,
toggle quoted message
Show quoted text
Oops, I will correct this by Saturday (one of the reasons why I need to lower my typing speed...). Thanks for catching this. Cheers, Joseph -----Original Message-----
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Paulius Sent: Friday, January 28, 2022 12:33 AM To: nvda-addons@nvda-addons.groups.io Subject: Re: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry Hello, Trying to expand my knowledge in add-on reviews. Since I'm a beginner in review process, didn't experiment with that much; Hope to test this more later today. After taking a quick look, I found one typo in Readme: Under the heading of "Sound Splitter settings", it's written "S;litter" instead of "Splitter". I may come with more review comments later. Note: I'm not very familiar with how flake8 exactly works, so I'm not sure if I can test this part deeply, but I think that's not necessary as I don't see all add-ons are using this parsing tool... Thanks. Best regards, Paulius |
|
|
|
Lukasz Golonka
Hi,
Basic review results: * License and copyright: pass * Documentation: pass * Security: pass * User experience: pass * Code and code comments: pass with some nits: - There are several misspells in the comments rright -> right, yilds -> yields - Docstring for executeAsynchronously should be tweaked as it still references stuff from Tony's add-on e.g.GlobalPlugin.script_editJupyter - All messages in the script and the script documentation itself don't have comments for translators. - I haven't tested this explicitly but the add-on probably wouldn't work in source copes of NVDA since it relies on NVDA's process name. I'd suggest to rely on the PID of the process if possible and comparing it with the result of os.getpid. - While I understand why you're monkeypatching nvwave (there is no better way for now) perhaps in the future it would be nice to add additional extension point into core of NVDA which would allow to execute arbitrary function after nvwave.WavePlayer.open executes. -- Regards Lukasz |
|
|
|
Hi,
toggle quoted message
Show quoted text
Yep, I'll take care of misspellings and tweak the help text for async generator. Tony, what do you think about these comments as Sound Splitter ultimately came from your code? Cheers, Joseph -----Original Message-----
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Lukasz Golonka via groups.io Sent: Friday, January 28, 2022 6:09 AM To: nvda-addons@nvda-addons.groups.io Subject: Re: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry Hi, Basic review results: * License and copyright: pass * Documentation: pass * Security: pass * User experience: pass * Code and code comments: pass with some nits: - There are several misspells in the comments rright -> right, yilds -> yields - Docstring for executeAsynchronously should be tweaked as it still references stuff from Tony's add-on e.g.GlobalPlugin.script_editJupyter - All messages in the script and the script documentation itself don't have comments for translators. - I haven't tested this explicitly but the add-on probably wouldn't work in source copes of NVDA since it relies on NVDA's process name. I'd suggest to rely on the PID of the process if possible and comparing it with the result of os.getpid. - While I understand why you're monkeypatching nvwave (there is no better way for now) perhaps in the future it would be nice to add additional extension point into core of NVDA which would allow to execute arbitrary function after nvwave.WavePlayer.open executes. -- Regards Lukasz |
|
|
|
Rowen Cary
Hello, If I remember correctly, the gesture NVDA+Alt+S for this add-on has been assigned to another add-on called "Sentence-Nav" by Tony. We'd better be able to resolve this known gesture conflict. best wishes |
|
|
|
Hi, If so, Tony, what do you think? Cheers, Joseph
From: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> On Behalf Of Rowen Cary
Sent: Friday, January 28, 2022 9:00 PM To: nvda-addons@nvda-addons.groups.io Subject: Re: [nvda-addons] Now official: Sound Splitter 22.02, requesting review before submitting to community add-ons registry
Hello, If I remember correctly, the gesture NVDA+Alt+S for this add-on has been assigned to another add-on called "Sentence-Nav" by Tony. We'd better be able to resolve this known gesture conflict. best wishes |
|
|
|
Tony Malykh
Yeah, I am guilty of all the spelling errors :)
toggle quoted message
Show quoted text
Doing getpid makes sense. Lucas, You raised a very good point about monkey patching. I think it is ok to let it go for now since everyone is doing that, but maybe we should think on a long-term solution to the monkey patching problem. I see more and more add-ons doing monkey patching various NVDA functions. While this allows add-ons to be extremely flexible, it also comes at a cost. This can easily cause incompatibility between two add-ons that try to monkey patch the same function in some incompatible way. For example the biggest offender seems to be speech.speech.speak function that is patched by my ad-ons Tony's enhancements, Bluetooth Audio, Phonetic Punctuation, and others, such as Character Information and translation add-ons among others. And there were incompatibilities regarding this function already reported. Moreover if NVAccess decides to change the signature of this function, it might break all the add-ons that rely on monkey patching it. So it would be good to extend proper add-on API to allow add-ons to modify speech without monkey patching. --Tony On 1/28/2022 10:43 AM, Joseph Lee wrote:
Hi, |
|
|
|
Tony Malykh
I removed NVDA+Alt+S from SentenceNav. I think that sound split
feature is way more userful and deserves this keystroke. On 1/28/2022 9:20 PM, Joseph Lee wrote:
|
|
|
|
Alberto Buffolino
Tony Malykh, il 29/01/2022 20.12, ha scritto:
For example the biggest offender seems to be speech.speech.speak function that is patched by my ad-ons Tony's enhancements, Bluetooth Audio, Phonetic Punctuation, and others, such as Character Information and translation add-ons among others. And there were incompatibilities regarding this function already reported.Alberto: Hi, also speechDictHandler.processText, even if it's not so used, maybe... I patched it in numberProcessing, and I'd want to do also in unicodeAscii (as PR contribution), but I found no way to combine the two add-ons features without problems. It should be possible to build a pipeline, queueing all functions (eventually less the original), but it's not so simple without a core method. I never investigated/understood well if extensionPoints can achieve a solution here, though. Alberto |
|
|
|
Hi all, Well, it is really official now: Sound Splitter was just approved for community add-ons website distribution. It can be found at: https://addons.nvda-project.org/addons/soundSplitter.en.html And, just like other add-ons, Add-on Updater will begin checking for updates to Sound Splitter add-on. Again thank you Tony for your hard work and blessings. Cheers, Joseph |
|
|
|
Hi all, At the moment Sound Splitter cannot be downloaded through community add-ons website. I'll provide an update once it is resolved. Cheers, Joseph |
|
|
|
Hi all, Now downloadable. Thanks. Cheers, Joseph |
|
|