Date   

Re: How to Read NVDA Addon Errors

Fawaz Abdul rahman
 

Hi,

I had the same issue, what I did is that I wrote python script separately, then moved to the addon file, just because it was easier to check the output.

And the common technique  instead of print(), ui.message

I really was thinking of asking the same question.

Thanks for bringing it up.

Sent from Mail for Windows 10

 

From: timothyjb310@...
Sent: Monday, June 21, 2021 4:43 PM
To: nvda-addons@groups.io
Subject: [nvda-addons] How to Read NVDA Addon Errors

 

Hi all,

 

I am new to the list, and just started learning how to develop NVDA addons. There is a particular addon that I want to contribute to, but I will post my questions concerning that in a separate thread.

 

My big question right now after reading through the NVDA addon guides is, where is error output going for my addons. For example, if I create an addon and I have a syntax error, or runtime error, where does that output go so that I can troubleshoot?

I am guessing that it is getting printed to some NVDA logs somewhere. Perhaps it would be helpful for new addon developers if this information was added to the addon guide here:

 

https://github.com/nvdaaddons/DevGuide/wiki/NVDA-Add-on-Development-Guide

 

This guide was helpful for getting started, although any additional resources on creating addons would be appreciated.

 

Thanks,


Timothy Breitenfeldt

 

 


Re: Procedure to request registration in the translations system

zvonimir stanečić, 9a5dsz
 

Hi Noelia!
Thanks to Reef for this.
Can you see, what can be done to re register weather plus>
Best,
Zvonimir


-----Исходное сообщение-----
От: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> От имени пользователя Noelia Ruiz
Отправлено: 21 июня 2021 г. 15:45
Кому: nvda-addons@nvda-addons.groups.io
Тема: [nvda-addons] Procedure to request registration in the translations system

Hi. Reef (NV Access)has updated the instructions about registration of add-ons to be translated using the translations system.

The registrations must be requested on this list, so that a member of the nvdaaddons organization can fork the corresponding repo, ensuring that a stable branch is in place.

I'm a mamber of nvdaaddons organization, so I'll fork pcKbBrl add-on, maintained by me.

Please, see instructions at

https://github.com/nvaccess/mrconfig/blob/master/readme.md


Procedure to request registration in the translations system

Noelia Ruiz
 

Hi. Reef (NV Access)has updated the instructions about registration of
add-ons to be translated using the translations system.

The registrations must be requested on this list, so that a member of
the nvdaaddons organization can fork the corresponding repo, ensuring
that a stable branch is in place.

I'm a mamber of nvdaaddons organization, so I'll fork pcKbBrl add-on,
maintained by me.

Please, see instructions at

https://github.com/nvaccess/mrconfig/blob/master/readme.md


How to Read NVDA Addon Errors

Timothy Breitenfeldt
 

Hi all,

 

I am new to the list, and just started learning how to develop NVDA addons. There is a particular addon that I want to contribute to, but I will post my questions concerning that in a separate thread.

 

My big question right now after reading through the NVDA addon guides is, where is error output going for my addons. For example, if I create an addon and I have a syntax error, or runtime error, where does that output go so that I can troubleshoot?

I am guessing that it is getting printed to some NVDA logs somewhere. Perhaps it would be helpful for new addon developers if this information was added to the addon guide here:

 

https://github.com/nvdaaddons/DevGuide/wiki/NVDA-Add-on-Development-Guide

 

This guide was helpful for getting started, although any additional resources on creating addons would be appreciated.

 

Thanks,


Timothy Breitenfeldt

 


Re: addonsHelp

Cyrille
 

Hello Rui and all

The request (PR) to have this add-on updated on the website is here:
http://github.com/nvaccess/addonFiles/pull/103

Many PRs have been merged to update add-ons on the website today. Unfortunately, it seems that Reef Turner expects to have all merge conflicts resolved before merging. You should merge master branch in yours and resolve the conflicts to have it finally merged.

I have had the same issue with Windows Magnifier. FYI, you can find the discussion here:
https://github.com/nvaccess/addonFiles/pull/103

Hope this helps.
Cheers,

Cyrille

 
De : "Sergio Gómez"
A : "nvda-addons@nvda-addons.groups.io"
Envoyé: lundi 21 Juin 2021 14:39
Objet : Re: [nvda-addons] addonsHelp
 

Thank you very much for the information!

 

De: Rui Fontes
Enviado: lunes, 21 de junio de 2021 13:47
Para: nvda-addons@nvda-addons.groups.io
Asunto: Re: [nvda-addons] addonsHelp

 

Soon, I suppose...

Two of my official add-ons, systrayList and wordCount were already updated...

The other two, addonsHelp and virtualReview, are waiting merging by Reef...

 

Rui Fontes

 

Às 12:18 de 21/06/2021, Sergio Gómez escreveu:

Hi!

 

When will this add-on be included on the web, updated, and will addonUpdater not offer the previous version again? I do not know if I have asked the question very understandable ... That is, was a request to extract this plugin to include it in the plugins web?

 

Thank you very much

 

Greetings

 

 

 


Re: requesting review, Direct Link addon

Nikola Jovic
 

Hi,
all cloud storage services provide this functionality.
However, the link which they copy by default often leads to their
website, and doesn't directly start the download right away.
In the case of Dropbox, for example, it asks you to sign in or create
an account, with a button called no thanks, download or something like
that.
Direct links will start the download right away, and as mentioned in
the addon readme will also potentially allow you to stream files in a
media player.

On 6/21/21, Brian's Mail list account via groups.io
<bglists=blueyonder.co.uk@groups.io> wrote:
Not sure what you mean by a direct link, as dropbox provides a copy link to

function in the context menu.
Brian

bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Fawaz Abdul rahman" <fawaz.ar94@gmail.com>
To: <nvda-addons@nvda-addons.groups.io>
Sent: Saturday, June 19, 2021 10:43 AM
Subject: Re: [nvda-addons] requesting review, Direct Link addon


Hi,

The methods are officially documented in their respective websites, OneDrive

is explained it its documentation, dropbox in the dropbox help etc.
From: zvonimir staneÄ ić, 9a5dsz
Sent: Saturday, June 19, 2021 12:30 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon



Hi,

Is it legal?





От: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io>

От имени Ð¿Ð¾Ð»ÑŒÐ·Ð¾Ð²Ð°Ñ‚ÐµÐ»Ñ Fawaz Abdul rahman
Отправлено: 19 Ð¸ÑŽÐ½Ñ 2021 г. 10:46
Кому: nvda-addons@nvda-addons.groups.io Integration
<nvda-addons@nvda-addons.groups.io>
Тема: [nvda-addons] requesting review, Direct Link addon



Hello,

I’ve written my first addon for nvda, I would like your feedback on it.

The addon converts the shared Dropbox, Google drive or OneDrive link to a
direct link, additionally, it creates a direct WhatsApp chat link if you
select a phone number.

the repository link: https://www.github.com/fawazar94/directlink

the download link:
https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

thanks.








Re: addonsHelp

Sergio Gómez
 

Thank you very much for the information!

 

De: Rui Fontes
Enviado: lunes, 21 de junio de 2021 13:47
Para: nvda-addons@nvda-addons.groups.io
Asunto: Re: [nvda-addons] addonsHelp

 

Soon, I suppose...

Two of my official add-ons, systrayList and wordCount were already updated...

The other two, addonsHelp and virtualReview, are waiting merging by Reef...

 

Rui Fontes

 

Às 12:18 de 21/06/2021, Sergio Gómez escreveu:

Hi!

 

When will this add-on be included on the web, updated, and will addonUpdater not offer the previous version again? I do not know if I have asked the question very understandable ... That is, was a request to extract this plugin to include it in the plugins web?

 

Thank you very much

 

Greetings

 

 


Re: addonsHelp

Rui Fontes
 

Soon, I suppose...

Two of my official add-ons, systrayList and wordCount were already updated...

The other two, addonsHelp and virtualReview, are waiting merging by Reef...


Rui Fontes


Às 12:18 de 21/06/2021, Sergio Gómez escreveu:

Hi!

 

When will this add-on be included on the web, updated, and will addonUpdater not offer the previous version again? I do not know if I have asked the question very understandable ... That is, was a request to extract this plugin to include it in the plugins web?

 

Thank you very much

 

Greetings

 


addonsHelp

Sergio Gómez
 

Hi!

 

When will this add-on be included on the web, updated, and will addonUpdater not offer the previous version again? I do not know if I have asked the question very understandable ... That is, was a request to extract this plugin to include it in the plugins web?

 

Thank you very much

 

Greetings

 


Re: requesting review, Direct Link addon

Brian's Mail list account
 

Not sure what you mean by a direct link, as dropbox provides a copy link to function in the context menu.
Brian

bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users

----- Original Message -----
From: "Fawaz Abdul rahman" <fawaz.ar94@gmail.com>
To: <nvda-addons@nvda-addons.groups.io>
Sent: Saturday, June 19, 2021 10:43 AM
Subject: Re: [nvda-addons] requesting review, Direct Link addon


Hi,

The methods are officially documented in their respective websites, OneDrive is explained it its documentation, dropbox in the dropbox help etc.
From: zvonimir stanečić, 9a5dsz
Sent: Saturday, June 19, 2021 12:30 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon



Hi,

Is it legal?





От: nvda-addons@nvda-addons.groups.io <nvda-addons@nvda-addons.groups.io> От имени пользователя Fawaz Abdul rahman
Отправлено: 19 июня 2021 г. 10:46
Кому: nvda-addons@nvda-addons.groups.io Integration <nvda-addons@nvda-addons.groups.io>
Тема: [nvda-addons] requesting review, Direct Link addon



Hello,

I’ve written my first addon for nvda, I would like your feedback on it.

The addon converts the shared Dropbox, Google drive or OneDrive link to a direct link, additionally, it creates a direct WhatsApp chat link if you select a phone number.

the repository link: https://www.github.com/fawazar94/directlink

the download link: https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

thanks.


Re: placeMarkers 16.0 . 0, available on the website

Noelia Ruiz
 

Sorry, I made a mistake: placeMarkers 16.0 is compatible with NVDA
2021.1 and beyond. I needed to made changes due to modifications
related to speech, and so this version is not compatible with NVDA
2019.3.
Cheers

2021-06-21 8:05 GMT+02:00, Noelia Ruiz via groups.io
<nrm1977=gmail.com@groups.io>:

This is compatible with NVDA 2019 and beyond. I"ll update the readme in the
next hours, but Reef (NV Access) has merged the pull request and the
download links to this version have been updated. Enjoy

Enviado desde mi iPhone





placeMarkers 16.0 . 0, available on the website

Noelia Ruiz
 

This is compatible with NVDA 2019 and beyond. I"ll update the readme in the next hours, but Reef (NV Access) has merged the pull request and the download links to this version have been updated. Enjoy

Enviado desde mi iPhone


Re: installTasks.py

Rui Fontes
 

Never mind!

Already found the problem! It was my mistake...


Rui Fontes



Às 21:46 de 20/06/2021, Rui Fontes via groups.io escreveu:

Hello!


In a installTasks.py I have the following routine:

def onInstall():
    configFilePath = os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName", "globalPlugins", "add-onName", "file.ini"))
    if os.path.isfile(configFilePath):
os.remove(os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName" + addonHandler.ADDON_PENDINGINSTALL_SUFFIX, "globalPlugins", "add-onName", "file.ini")))
        os.rename(configFilePath, os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName" + addonHandler.ADDON_PENDINGINSTALL_SUFFIX, "globalPlugins", "add-onName", "file.ini")))

and it was working, saving the file.ini from the old installation and copying to the new installation.

Now it is not working... What to do?


Rui Fontes








installTasks.py

Rui Fontes
 

Hello!


In a installTasks.py I have the following routine:

def onInstall():
    configFilePath = os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName", "globalPlugins", "add-onName", "file.ini"))
    if os.path.isfile(configFilePath):
os.remove(os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName" + addonHandler.ADDON_PENDINGINSTALL_SUFFIX, "globalPlugins", "add-onName", "file.ini")))
        os.rename(configFilePath, os.path.abspath(os.path.join(globalVars.appArgs.configPath, "addons", "add-onName" + addonHandler.ADDON_PENDINGINSTALL_SUFFIX, "globalPlugins", "add-onName", "file.ini")))

and it was working, saving the file.ini from the old installation and copying to the new installation.

Now it is not working... What to do?


Rui Fontes


Re: requesting review, Direct Link addon

Noelia Ruiz
 

Hello. Yes please, don't esitate to email me privately.
Time ago, I read that, since a person requested a review, a week or so
should be used so people have a chance to provide feedback.
I think it's a good practice to ensure more people can participate in
reviews and also to try that add-ons are posted with a minimum of
quality to be improved later.
Waiting for your reply off list.
Thanks

2021-06-20 10:21 GMT+02:00, Fawaz Abdul rahman <fawaz.ar94@gmail.com>:

Hi,

It will be nice to have it posted on the website.

Thanks a lot for the links. I’ve started reading.

It is ok to email you off the list? I  have 2-3 clarification question.

Thanks.



Sent from Mail for Windows 10



From: Noelia Ruiz
Sent: Sunday, June 20, 2021 9:52 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon



Hello:



Linting and comments for translators are not mandatory in terms of

basic review, that is what is required if you want your add-on to be

posted on the website.



But you can see documentation about linting and comments for translators at:



https://github.com/nvaccess/nvda/wiki/Contributing



Please see the section about code style, where a a link to a document

about linting is provided.



You can find GitHub Actions at



https://github.com/nvdaes/clipContentsDesigner



See subfolder .github/workflows and yaml files.



Oleksandr created a pull request with type hints and a yaml file to

check them with Mypy.



Feel free to use them.

About checking for translator comments, we create the pot file without

using executable files. Just we install gettext in the GitHub virtual

machines, in Ubuntu. Feel free to adapt all this to your needs.



For linting, we use the setup.cfg and requirements.txt that you can

find in the root folder, to install flake8, the linter.

This is also useful to detect, for example, if we forget to remove an

import sentence not needed in a different version of the add-on,

syntax errors, etc.

See the root folder of the repo for more details. we use exactly the

same rules applied by NVDA. If you prefer, remove what you want.



Some rules are:



- Write # then space then comment, for example for copyright and other
comments.



Just a blank line between functions contained in a class, but two

after functions when are followed by a class. Don't worry, it's easy

once you see a few errors.



Cheers



2021-06-20 8:24 GMT+02:00, Fawaz Abdul rahman <fawaz.ar94@gmail.com>:

Hello!
First of all, thanks a lot  for the review and feedback, as I said this is
the first time, I would love to improve and contribute more.
My comment after each point:
- I've seen at least a bad typo in the documentation: after a dot a
character non capitalized (after a quotation. I'm not a native English
speaker, but I think this is not right:
this file for viruses." in that case, you have to click on download
anyway
link.
This might slipped because the message was copied from the google site
directly, will fix it, thanks.
- You may use headings of level 1 and then 2 for a better structured
HTML. You may see examples of other add-ons that you like.
Will do it.
- Why are you using HTML markup in markdown to indicate lists instead
of just * or -?
I did this only for the last list, for whatever reason it refused to show
as
a list, I’ve tried around 4 times, each time it was showing (-) and (*) in
the HTML file, I’ve tried with space and with tab, both was showing just
as
it is and only for the last list, thus, I decided to go with html.
I’ll try again with markup and see if it’ll work.
- You may add commends for translators and, additionally, just if you
find it useful, lint your add-on.
I know what is lint but not sure how to use for the addon and where to
find
one, not sure if there is a specific one for this etc, but I’ll google it
now.
For the comment because of the messages are quite few I just didn’t know
what to put there, mostly I would be repeating the similar things, so I
just
thought I wouldn’t be needing it, I tried as best as I can to be clear
with
variable and function names.
However, if needed I can write it for sure (in the source file).
Personally, and I know that also Oleksandr (mentioned by you in your
code) use GitHub Actions that can automate checks to see if some
comment for translators is missing or if the add-on contains linter
errors.
May I know where I can find more info about this?
These actions have been created by Mesar Hameed, Oleksandr and me,
following other documentation. Mesar created a workflow to check that
files don't contain UTF8-Bom, which may create issues in translating,
and help me a lot to create other actions and test.
Oleksandr created an action to check type hints, used in the code that
you borrow from him.
You guys are amazing, I know dr.mesar from Arabic nvda list back in the
days, I’ve spoken with him quite few times years ago, (around 9-10).
Any links I should check them out (even for knowledge), please share, I’ll
be grateful.
Once again thanks for your feedback, I’ll fix the documentation and some
comments for the translators and email back.
Best regards
Sent from Mail for Windows 10
From: Noelia Ruiz
Sent: Sunday, June 20, 2021 8:48 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon
I've tested WhatsApp functionality right now, and it seems to be right.
I've also seen the source code and documentation.
In terms of basic review, if more testing (for example what Sergio has
pointed out) confirms that the add-on works as expected, imo licesne
and copyright, user experience, security and documentation pass:
- I don't find commands or other features that causes an unexpected
behavior.
- Documentation looks like understandable and enough to use the add-on.
- Nothing harmful in terms of privacy,, system files, etc.
- License is GPL 2 and your name is reflected in Copyright header.
Other feedback:
- I've seen at least a bad typo in the documentation: after a dot a
character non capitalized (after a quotation. I'm not a native English
speaker, but I think this is not right:
this file for viruses." in that case, you have to click on download
anyway
link.
- You may use headings of level 1 and then 2 for a better structured
HTML. You may see examples of other add-ons that you like.
- Why are you using HTML markup in markdown to indicate lists instead
of just * or -?
- You may add commends for translators and, additionally, just if you
find it useful, lint your add-on.
Personally, and I know that also Oleksandr (mentioned by you in your
code) use GitHub Actions that can automate checks to see if some
comment for translators is missing or if the add-on contains linter
errors.
These actions have been created by Mesar Hameed, Oleksandr and me,
following other documentation. Mesar created a workflow to check that
files don't contain UTF8-Bom, which may create issues in translating,
and help me a lot to create other actions and test.
Oleksandr created an action to check type hints, used in the code that
you borrow from him.
Hope this helps and thanks for your work!
2021-06-19 22:48 GMT+02:00, Sergio Gómez <listas.sergio.gomez@gmail.com>:
Hello again!
I wanted to tell you two things, which, I don't know if it's me, but when
converting links from OneDrive or Dropbox with the add-on, and pasting
these
in a web browser, they give an error, in the case of Dropbox it says that
the page cannot be found.
Converting Google Drive links seems to be going great.
Thank you very much for sharing this plugin, its function is great.
Greetings
De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 22:28
Para: nvda-addons@nvda-addons.groups.io
Asunto: Re: [nvda-addons] requesting review, Direct Link addon
Thanks a lot.
Sent from Mail for Windows 10
From: Sergio Gómez
Sent: Saturday, June 19, 2021 9:48 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon
Hi!
I give you my sincere thanks for such a good complement, congratulations!
The function is great, more than great. It is something that I was
looking
for for days, but could not find it, now I finally have it, in addition
to
NVDA also, it could not be better.
Congratulations on the add-on, keep it up!
Greetings
De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 10:46
Para: nvda-addons@nvda-addons.groups.io Integration
Asunto: [nvda-addons] requesting review, Direct Link addon
Hello,
I’ve written my first addon for nvda, I would like your feedback on it.
The addon converts the shared Dropbox, Google drive or OneDrive link to a
 direct link, additionally, it creates a direct WhatsApp chat link if you
select a phone number.
the repository link:  https://www.github.com/fawazar94/directlink
the download link:
https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon
thanks.
Sent from Mail for Windows 10











Re: requesting review, Direct Link addon

Fawaz Abdul rahman
 

Hi,

It will be nice to have it posted on the website.

Thanks a lot for the links. I’ve started reading.

It is ok to email you off the list? I  have 2-3 clarification question.

Thanks.

 

Sent from Mail for Windows 10

 

From: Noelia Ruiz
Sent: Sunday, June 20, 2021 9:52 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon

 

Hello:

 

Linting and comments for translators are not mandatory in terms of

basic review, that is what is required if you want your add-on to be

posted on the website.

 

But you can see documentation about linting and comments for translators at:

 

https://github.com/nvaccess/nvda/wiki/Contributing

 

Please see the section about code style, where a a link to a document

about linting is provided.

 

You can find GitHub Actions at

 

https://github.com/nvdaes/clipContentsDesigner

 

See subfolder .github/workflows and yaml files.

 

Oleksandr created a pull request with type hints and a yaml file to

check them with Mypy.

 

Feel free to use them.

About checking for translator comments, we create the pot file without

using executable files. Just we install gettext in the GitHub virtual

machines, in Ubuntu. Feel free to adapt all this to your needs.

 

For linting, we use the setup.cfg and requirements.txt that you can

find in the root folder, to install flake8, the linter.

This is also useful to detect, for example, if we forget to remove an

import sentence not needed in a different version of the add-on,

syntax errors, etc.

See the root folder of the repo for more details. we use exactly the

same rules applied by NVDA. If you prefer, remove what you want.

 

Some rules are:

 

- Write # then space then comment, for example for copyright and other comments.

 

Just a blank line between functions contained in a class, but two

after functions when are followed by a class. Don't worry, it's easy

once you see a few errors.

 

Cheers

 

2021-06-20 8:24 GMT+02:00, Fawaz Abdul rahman <fawaz.ar94@...>:

> Hello!

> First of all, thanks a lot  for the review and feedback, as I said this is

> the first time, I would love to improve and contribute more.

> My comment after each point:

> - I've seen at least a bad typo in the documentation: after a dot a

> character non capitalized (after a quotation. I'm not a native English

> speaker, but I think this is not right:

>> this file for viruses." in that case, you have to click on download anyway

>> link.

> This might slipped because the message was copied from the google site

> directly, will fix it, thanks.

> - You may use headings of level 1 and then 2 for a better structured

> HTML. You may see examples of other add-ons that you like.

> Will do it.

> - Why are you using HTML markup in markdown to indicate lists instead

> of just * or -?

> I did this only for the last list, for whatever reason it refused to show as

> a list, I’ve tried around 4 times, each time it was showing (-) and (*) in

> the HTML file, I’ve tried with space and with tab, both was showing just as

> it is and only for the last list, thus, I decided to go with html.

> I’ll try again with markup and see if it’ll work.

> - You may add commends for translators and, additionally, just if you

> find it useful, lint your add-on.

> I know what is lint but not sure how to use for the addon and where to find

> one, not sure if there is a specific one for this etc, but I’ll google it

> now.

> For the comment because of the messages are quite few I just didn’t know

> what to put there, mostly I would be repeating the similar things, so I just

> thought I wouldn’t be needing it, I tried as best as I can to be clear with

> variable and function names.

> However, if needed I can write it for sure (in the source file).

> Personally, and I know that also Oleksandr (mentioned by you in your

> code) use GitHub Actions that can automate checks to see if some

> comment for translators is missing or if the add-on contains linter

> errors.

> May I know where I can find more info about this?

> These actions have been created by Mesar Hameed, Oleksandr and me,

> following other documentation. Mesar created a workflow to check that

> files don't contain UTF8-Bom, which may create issues in translating,

> and help me a lot to create other actions and test.

> Oleksandr created an action to check type hints, used in the code that

> you borrow from him.

> You guys are amazing, I know dr.mesar from Arabic nvda list back in the

> days, I’ve spoken with him quite few times years ago, (around 9-10).

> Any links I should check them out (even for knowledge), please share, I’ll

> be grateful.

> Once again thanks for your feedback, I’ll fix the documentation and some

> comments for the translators and email back.

> Best regards

> Sent from Mail for Windows 10

> From: Noelia Ruiz

> Sent: Sunday, June 20, 2021 8:48 AM

> To: nvda-addons@nvda-addons.groups.io

> Subject: Re: [nvda-addons] requesting review, Direct Link addon

> I've tested WhatsApp functionality right now, and it seems to be right.

> I've also seen the source code and documentation.

> In terms of basic review, if more testing (for example what Sergio has

> pointed out) confirms that the add-on works as expected, imo licesne

> and copyright, user experience, security and documentation pass:

> - I don't find commands or other features that causes an unexpected

> behavior.

> - Documentation looks like understandable and enough to use the add-on.

> - Nothing harmful in terms of privacy,, system files, etc.

> - License is GPL 2 and your name is reflected in Copyright header.

> Other feedback:

> - I've seen at least a bad typo in the documentation: after a dot a

> character non capitalized (after a quotation. I'm not a native English

> speaker, but I think this is not right:

>> this file for viruses." in that case, you have to click on download anyway

>> link.

> - You may use headings of level 1 and then 2 for a better structured

> HTML. You may see examples of other add-ons that you like.

> - Why are you using HTML markup in markdown to indicate lists instead

> of just * or -?

> - You may add commends for translators and, additionally, just if you

> find it useful, lint your add-on.

> Personally, and I know that also Oleksandr (mentioned by you in your

> code) use GitHub Actions that can automate checks to see if some

> comment for translators is missing or if the add-on contains linter

> errors.

> These actions have been created by Mesar Hameed, Oleksandr and me,

> following other documentation. Mesar created a workflow to check that

> files don't contain UTF8-Bom, which may create issues in translating,

> and help me a lot to create other actions and test.

> Oleksandr created an action to check type hints, used in the code that

> you borrow from him.

> Hope this helps and thanks for your work!

> 2021-06-19 22:48 GMT+02:00, Sergio Gómez <listas.sergio.gomez@...>:

>> Hello again!

>> 

>> 

>> 

>> I wanted to tell you two things, which, I don't know if it's me, but when

>> converting links from OneDrive or Dropbox with the add-on, and pasting

>> these

>> in a web browser, they give an error, in the case of Dropbox it says that

>> the page cannot be found.

>> 

>> 

>> 

>> Converting Google Drive links seems to be going great.

>> 

>> 

>> 

>> Thank you very much for sharing this plugin, its function is great.

>> 

>> 

>> 

>> Greetings

>> 

>> 

>> 

>> De: Fawaz Abdul rahman

>> Enviado: sábado, 19 de junio de 2021 22:28

>> Para: nvda-addons@nvda-addons.groups.io

>> Asunto: Re: [nvda-addons] requesting review, Direct Link addon

>> 

>> 

>> 

>> Thanks a lot.

>> 

>> 

>> 

>> Sent from Mail for Windows 10

>> 

>> 

>> 

>> From: Sergio Gómez

>> Sent: Saturday, June 19, 2021 9:48 PM

>> To: nvda-addons@nvda-addons.groups.io

>> Subject: Re: [nvda-addons] requesting review, Direct Link addon

>> 

>> 

>> 

>> Hi!

>> 

>> 

>> 

>> I give you my sincere thanks for such a good complement, congratulations!

>> The function is great, more than great. It is something that I was looking

>> for for days, but could not find it, now I finally have it, in addition to

>> NVDA also, it could not be better.

>> 

>> 

>> 

>> Congratulations on the add-on, keep it up!

>> 

>> 

>> 

>> Greetings

>> 

>> 

>> 

>> De: Fawaz Abdul rahman

>> Enviado: sábado, 19 de junio de 2021 10:46

>> Para: nvda-addons@nvda-addons.groups.io Integration

>> Asunto: [nvda-addons] requesting review, Direct Link addon

>> 

>> 

>> 

>> Hello,

>> 

>> I’ve written my first addon for nvda, I would like your feedback on it.

>> 

>> The addon converts the shared Dropbox, Google drive or OneDrive link to a

>>  direct link, additionally, it creates a direct WhatsApp chat link if you

>> select a phone number.

>> 

>> the repository link:  https://www.github.com/fawazar94/directlink

>> 

>> the download link:

>> https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

>> 

>> thanks.

>> 

>> 

>> 

>> 

>> 

>> Sent from Mail for Windows 10

>> 

>> 

>> 

>> 

>> 

>> 

>> 

>> 

>> 

>> 

>

 

 

 

 

 


Re: requesting review, Direct Link addon

Rémy Ruiz
 

Hi,
See this page for Markdown
Cheers.
Rémy

Le 20/06/2021 à 08:24, Fawaz Abdul rahman a écrit :

Hello!

First of all, thanks a lot  for the review and feedback, as I said this is the first time, I would love to improve and contribute more.

My comment after each point:

- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

> this file for viruses." in that case, you have to click on download anyway link.

This might slipped because the message was copied from the google site directly, will fix it, thanks.

- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

Will do it.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

I did this only for the last list, for whatever reason it refused to show as a list, I’ve tried around 4 times, each time it was showing (-) and (*) in the HTML file, I’ve tried with space and with tab, both was showing just as it is and only for the last list, thus, I decided to go with html.

I’ll try again with markup and see if it’ll work.

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.

I know what is lint but not sure how to use for the addon and where to find one, not sure if there is a specific one for this etc, but I’ll google it now.

For the comment because of the messages are quite few I just didn’t know what to put there, mostly I would be repeating the similar things, so I just thought I wouldn’t be needing it, I tried as best as I can to be clear with variable and function names.

However, if needed I can write it for sure (in the source file).

 

Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.

May I know where I can find more info about this?

These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.

You guys are amazing, I know dr.mesar from Arabic nvda list back in the days, I’ve spoken with him quite few times years ago, (around 9-10).

Any links I should check them out (even for knowledge), please share, I’ll be grateful.

Once again thanks for your feedback, I’ll fix the documentation and some comments for the translators and email back.

Best regards

 

Sent from Mail for Windows 10

 

From: Noelia Ruiz
Sent: Sunday, June 20, 2021 8:48 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon

 

I've tested WhatsApp functionality right now, and it seems to be right.

 

I've also seen the source code and documentation.

 

In terms of basic review, if more testing (for example what Sergio has

pointed out) confirms that the add-on works as expected, imo licesne

and copyright, user experience, security and documentation pass:

 

- I don't find commands or other features that causes an unexpected behavior.

- Documentation looks like understandable and enough to use the add-on.

- Nothing harmful in terms of privacy,, system files, etc.

- License is GPL 2 and your name is reflected in Copyright header.

 

 

Other feedback:

 

- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

> this file for viruses." in that case, you have to click on download anyway link.

- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.

 

Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.

 

These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.

 

Hope this helps and thanks for your work!

 

 

2021-06-19 22:48 GMT+02:00, Sergio Gómez <listas.sergio.gomez@...>:

> Hello again!

> I wanted to tell you two things, which, I don't know if it's me, but when

> converting links from OneDrive or Dropbox with the add-on, and pasting these

> in a web browser, they give an error, in the case of Dropbox it says that

> the page cannot be found.

> Converting Google Drive links seems to be going great.

> Thank you very much for sharing this plugin, its function is great.

> Greetings

> De: Fawaz Abdul rahman

> Enviado: sábado, 19 de junio de 2021 22:28

> Para: nvda-addons@nvda-addons.groups.io

> Asunto: Re: [nvda-addons] requesting review, Direct Link addon

> Thanks a lot.

> Sent from Mail for Windows 10

> From: Sergio Gómez

> Sent: Saturday, June 19, 2021 9:48 PM

> To: nvda-addons@nvda-addons.groups.io

> Subject: Re: [nvda-addons] requesting review, Direct Link addon

> Hi!

> I give you my sincere thanks for such a good complement, congratulations!

> The function is great, more than great. It is something that I was looking

> for for days, but could not find it, now I finally have it, in addition to

> NVDA also, it could not be better.

> Congratulations on the add-on, keep it up!

> Greetings

> De: Fawaz Abdul rahman

> Enviado: sábado, 19 de junio de 2021 10:46

> Para: nvda-addons@nvda-addons.groups.io Integration

> Asunto: [nvda-addons] requesting review, Direct Link addon

> Hello,

> I’ve written my first addon for nvda, I would like your feedback on it.

> The addon converts the shared Dropbox, Google drive or OneDrive link to a

>  direct link, additionally, it creates a direct WhatsApp chat link if you

> select a phone number.

> the repository link:  https://www.github.com/fawazar94/directlink

> the download link:

> https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

> thanks.

> Sent from Mail for Windows 10

>

 

 

 

 

 


Re: requesting review, Direct Link addon

Noelia Ruiz
 

Hello:

Linting and comments for translators are not mandatory in terms of
basic review, that is what is required if you want your add-on to be
posted on the website.

But you can see documentation about linting and comments for translators at:

https://github.com/nvaccess/nvda/wiki/Contributing

Please see the section about code style, where a a link to a document
about linting is provided.

You can find GitHub Actions at

https://github.com/nvdaes/clipContentsDesigner

See subfolder .github/workflows and yaml files.

Oleksandr created a pull request with type hints and a yaml file to
check them with Mypy.

Feel free to use them.
About checking for translator comments, we create the pot file without
using executable files. Just we install gettext in the GitHub virtual
machines, in Ubuntu. Feel free to adapt all this to your needs.

For linting, we use the setup.cfg and requirements.txt that you can
find in the root folder, to install flake8, the linter.
This is also useful to detect, for example, if we forget to remove an
import sentence not needed in a different version of the add-on,
syntax errors, etc.
See the root folder of the repo for more details. we use exactly the
same rules applied by NVDA. If you prefer, remove what you want.

Some rules are:

- Write # then space then comment, for example for copyright and other comments.

Just a blank line between functions contained in a class, but two
after functions when are followed by a class. Don't worry, it's easy
once you see a few errors.

Cheers

2021-06-20 8:24 GMT+02:00, Fawaz Abdul rahman <fawaz.ar94@gmail.com>:

Hello!

First of all, thanks a lot  for the review and feedback, as I said this is
the first time, I would love to improve and contribute more.

My comment after each point:

- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

this file for viruses." in that case, you have to click on download anyway
link.
This might slipped because the message was copied from the google site
directly, will fix it, thanks.

- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

Will do it.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

I did this only for the last list, for whatever reason it refused to show as
a list, I’ve tried around 4 times, each time it was showing (-) and (*) in
the HTML file, I’ve tried with space and with tab, both was showing just as
it is and only for the last list, thus, I decided to go with html.

I’ll try again with markup and see if it’ll work.

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.

I know what is lint but not sure how to use for the addon and where to find
one, not sure if there is a specific one for this etc, but I’ll google it
now.

For the comment because of the messages are quite few I just didn’t know
what to put there, mostly I would be repeating the similar things, so I just
thought I wouldn’t be needing it, I tried as best as I can to be clear with
variable and function names.

However, if needed I can write it for sure (in the source file).



Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.

May I know where I can find more info about this?

These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.

You guys are amazing, I know dr.mesar from Arabic nvda list back in the
days, I’ve spoken with him quite few times years ago, (around 9-10).

Any links I should check them out (even for knowledge), please share, I’ll
be grateful.

Once again thanks for your feedback, I’ll fix the documentation and some
comments for the translators and email back.

Best regards



Sent from Mail for Windows 10



From: Noelia Ruiz
Sent: Sunday, June 20, 2021 8:48 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon



I've tested WhatsApp functionality right now, and it seems to be right.



I've also seen the source code and documentation.



In terms of basic review, if more testing (for example what Sergio has

pointed out) confirms that the add-on works as expected, imo licesne

and copyright, user experience, security and documentation pass:



- I don't find commands or other features that causes an unexpected
behavior.

- Documentation looks like understandable and enough to use the add-on.

- Nothing harmful in terms of privacy,, system files, etc.

- License is GPL 2 and your name is reflected in Copyright header.





Other feedback:



- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

this file for viruses." in that case, you have to click on download anyway
link.
- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.



Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.



These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.



Hope this helps and thanks for your work!





2021-06-19 22:48 GMT+02:00, Sergio Gómez <listas.sergio.gomez@gmail.com>:

Hello again!
I wanted to tell you two things, which, I don't know if it's me, but when
converting links from OneDrive or Dropbox with the add-on, and pasting
these
in a web browser, they give an error, in the case of Dropbox it says that
the page cannot be found.
Converting Google Drive links seems to be going great.
Thank you very much for sharing this plugin, its function is great.
Greetings
De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 22:28
Para: nvda-addons@nvda-addons.groups.io
Asunto: Re: [nvda-addons] requesting review, Direct Link addon
Thanks a lot.
Sent from Mail for Windows 10
From: Sergio Gómez
Sent: Saturday, June 19, 2021 9:48 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon
Hi!
I give you my sincere thanks for such a good complement, congratulations!
The function is great, more than great. It is something that I was looking
for for days, but could not find it, now I finally have it, in addition to
NVDA also, it could not be better.
Congratulations on the add-on, keep it up!
Greetings
De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 10:46
Para: nvda-addons@nvda-addons.groups.io Integration
Asunto: [nvda-addons] requesting review, Direct Link addon
Hello,
I’ve written my first addon for nvda, I would like your feedback on it.
The addon converts the shared Dropbox, Google drive or OneDrive link to a
 direct link, additionally, it creates a direct WhatsApp chat link if you
select a phone number.
the repository link:  https://www.github.com/fawazar94/directlink
the download link:
https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon
thanks.
Sent from Mail for Windows 10











Re: requesting review, Direct Link addon

Fawaz Abdul rahman
 

Hello!

First of all, thanks a lot  for the review and feedback, as I said this is the first time, I would love to improve and contribute more.

My comment after each point:

- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

> this file for viruses." in that case, you have to click on download anyway link.

This might slipped because the message was copied from the google site directly, will fix it, thanks.

- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

Will do it.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

I did this only for the last list, for whatever reason it refused to show as a list, I’ve tried around 4 times, each time it was showing (-) and (*) in the HTML file, I’ve tried with space and with tab, both was showing just as it is and only for the last list, thus, I decided to go with html.

I’ll try again with markup and see if it’ll work.

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.

I know what is lint but not sure how to use for the addon and where to find one, not sure if there is a specific one for this etc, but I’ll google it now.

For the comment because of the messages are quite few I just didn’t know what to put there, mostly I would be repeating the similar things, so I just thought I wouldn’t be needing it, I tried as best as I can to be clear with variable and function names.

However, if needed I can write it for sure (in the source file).

 

Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.

May I know where I can find more info about this?

These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.

You guys are amazing, I know dr.mesar from Arabic nvda list back in the days, I’ve spoken with him quite few times years ago, (around 9-10).

Any links I should check them out (even for knowledge), please share, I’ll be grateful.

Once again thanks for your feedback, I’ll fix the documentation and some comments for the translators and email back.

Best regards

 

Sent from Mail for Windows 10

 

From: Noelia Ruiz
Sent: Sunday, June 20, 2021 8:48 AM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon

 

I've tested WhatsApp functionality right now, and it seems to be right.

 

I've also seen the source code and documentation.

 

In terms of basic review, if more testing (for example what Sergio has

pointed out) confirms that the add-on works as expected, imo licesne

and copyright, user experience, security and documentation pass:

 

- I don't find commands or other features that causes an unexpected behavior.

- Documentation looks like understandable and enough to use the add-on.

- Nothing harmful in terms of privacy,, system files, etc.

- License is GPL 2 and your name is reflected in Copyright header.

 

 

Other feedback:

 

- I've seen at least a bad typo in the documentation: after a dot a

character non capitalized (after a quotation. I'm not a native English

speaker, but I think this is not right:

> this file for viruses." in that case, you have to click on download anyway link.

- You may use headings of level 1 and then 2 for a better structured

HTML. You may see examples of other add-ons that you like.

- Why are you using HTML markup in markdown to indicate lists instead

of just * or -?

- You may add commends for translators and, additionally, just if you

find it useful, lint your add-on.

 

Personally, and I know that also Oleksandr (mentioned by you in your

code) use GitHub Actions that can automate checks to see if some

comment for translators is missing or if the add-on contains linter

errors.

 

These actions have been created by Mesar Hameed, Oleksandr and me,

following other documentation. Mesar created a workflow to check that

files don't contain UTF8-Bom, which may create issues in translating,

and help me a lot to create other actions and test.

Oleksandr created an action to check type hints, used in the code that

you borrow from him.

 

Hope this helps and thanks for your work!

 

 

2021-06-19 22:48 GMT+02:00, Sergio Gómez <listas.sergio.gomez@...>:

> Hello again!

> I wanted to tell you two things, which, I don't know if it's me, but when

> converting links from OneDrive or Dropbox with the add-on, and pasting these

> in a web browser, they give an error, in the case of Dropbox it says that

> the page cannot be found.

> Converting Google Drive links seems to be going great.

> Thank you very much for sharing this plugin, its function is great.

> Greetings

> De: Fawaz Abdul rahman

> Enviado: sábado, 19 de junio de 2021 22:28

> Para: nvda-addons@nvda-addons.groups.io

> Asunto: Re: [nvda-addons] requesting review, Direct Link addon

> Thanks a lot.

> Sent from Mail for Windows 10

> From: Sergio Gómez

> Sent: Saturday, June 19, 2021 9:48 PM

> To: nvda-addons@nvda-addons.groups.io

> Subject: Re: [nvda-addons] requesting review, Direct Link addon

> Hi!

> I give you my sincere thanks for such a good complement, congratulations!

> The function is great, more than great. It is something that I was looking

> for for days, but could not find it, now I finally have it, in addition to

> NVDA also, it could not be better.

> Congratulations on the add-on, keep it up!

> Greetings

> De: Fawaz Abdul rahman

> Enviado: sábado, 19 de junio de 2021 10:46

> Para: nvda-addons@nvda-addons.groups.io Integration

> Asunto: [nvda-addons] requesting review, Direct Link addon

> Hello,

> I’ve written my first addon for nvda, I would like your feedback on it.

> The addon converts the shared Dropbox, Google drive or OneDrive link to a

>  direct link, additionally, it creates a direct WhatsApp chat link if you

> select a phone number.

> the repository link:  https://www.github.com/fawazar94/directlink

> the download link:

> https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

> thanks.

> Sent from Mail for Windows 10

>

 

 

 

 

 


Re: requesting review, Direct Link addon

Fawaz Abdul rahman
 

Hi,

Me and a friend of mine just tried all links, it is working fine, either with alt+nvda+shift+l to open in browser or to just paste in the address bar. Once the link is converted, it is in your clipboard.

If you are having the issue still, can you share the link you are having the issue with?

Feel free to email me privately too.

Thanks

 

Sent from Mail for Windows 10

 

From: Sergio Gómez
Sent: Saturday, June 19, 2021 11:48 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon

 

Hello again!

 

I wanted to tell you two things, which, I don't know if it's me, but when converting links from OneDrive or Dropbox with the add-on, and pasting these in a web browser, they give an error, in the case of Dropbox it says that the page cannot be found.

 

Converting Google Drive links seems to be going great.

 

Thank you very much for sharing this plugin, its function is great.

 

Greetings

 

De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 22:28
Para: nvda-addons@nvda-addons.groups.io
Asunto: Re: [nvda-addons] requesting review, Direct Link addon

 

Thanks a lot.

 

Sent from Mail for Windows 10

 

From: Sergio Gómez
Sent: Saturday, June 19, 2021 9:48 PM
To: nvda-addons@nvda-addons.groups.io
Subject: Re: [nvda-addons] requesting review, Direct Link addon

 

Hi!

 

I give you my sincere thanks for such a good complement, congratulations! The function is great, more than great. It is something that I was looking for for days, but could not find it, now I finally have it, in addition to NVDA also, it could not be better.

 

Congratulations on the add-on, keep it up!

 

Greetings

 

De: Fawaz Abdul rahman
Enviado: sábado, 19 de junio de 2021 10:46
Para: nvda-addons@nvda-addons.groups.io Integration
Asunto: [nvda-addons] requesting review, Direct Link addon

 

Hello,

I’ve written my first addon for nvda, I would like your feedback on it.

The addon converts the shared Dropbox, Google drive or OneDrive link to a  direct link, additionally, it creates a direct WhatsApp chat link if you select a phone number.

the repository link:  https://www.github.com/fawazar94/directlink

the download link: https://github.com/fawazar94/DirectLink/releases/download/1.0/directLink-1.0.nvda-addon

thanks.

 

 

Sent from Mail for Windows 10

 

 

 

 

 

741 - 760 of 16478