toggle quoted messageShow quoted text
On Mon, 12 Aug 2019, Tyler Spivey wrote:
Because addons can easily be uploaded as a GitHub release.
Can you download .nvda-addon files from GitHub directly from a repo?
On 8/12/2019 1:26 PM, Luke Davis wrote:
Perhaps I am just being dense, but why does the .gitignore included with the addontemplate repo, exclude .nvda-addon files from being uploaded?
Being able to push the end result of an add-on package to a publicly accessible URL, seems like a perfectly reasonable outcome to me. Obviously it can be done by removing the line from .gitignore, or by using a force, but I am interested in the reason why this is the default.
It is not as if, in the vast majority of cases, the add-on package is likely to include compiled code, that may only run on certain platforms. NVDA itself only runs on exactly one kind of platform, so there are no non-portability of compiled binaries here, and as I said most add-ons don't include compiled code anyway.
I can understand if it is an issue of being concerned that the .nvda-addon file will become desynchronized from the contents of the repository, as can easily happen if new code is pushed, but no rebuild is done. However, if people are following the versioning scheme mandated by the community add-ons process, that will not be a real issue, as the add-on file will indicate its version number at all times, and if its stored in the master branch, some repo instability should be expected. If it's stored in the stable branch, I am back to my original question: what's the downside?
As an aside: shouldn't the repo be called "addonTemplate" in order to be consistent with other things?