Re: Braille configuration key error in last alpha


Javi Domínguez
 

Hello, Cyrille.


Thanks for the clarification. I will adapt my addons to be compatible with this change.


This warn appeared on a clean copy of alpha, however when upgrading a copy from 2022.4beta3 to alpha, the noMessageTimeout key is still present but has no effect. This is irrelevant for the user but for an addon developer it can be inconvenient. Without warning KeyError: 'noMessageTimeout' I would not understand why my code has no effect, It would have taken longer to discover the cause and fix it. Obsolete keys shouldn't be removed when upgrading?


Greetings


El 26/11/2022 a las 22:45, Cyrille via groups.io escribió:

Hi Javi

Yes this key has been removed as written in the change log in "API Breaking Changes" section:
- The configuration specification has been altered, keys have been removed or modified (#14233).
  (...)
  - In ``[braille]`` section:
    - ``noMessageTimeout`` has been removed, replaced by a value for ``showMessages``.
    (...)

Actually, the alpha branch already contains compatibility breaking changes that should land in NVDA 2023.1.

Let me know if you need more information; I am the author of this PR.

Cheers,

Cyrille


On Sat, Nov 26, 2022 at 09:19 PM, Javi Domínguez wrote:

Hello.

 

I have this problem with the latest alpha, 27190,85efa6d7 (2023.1.0.27190) in one of my addons:

 

    self.brailleMessageTimeout = config.conf["braille"]["noMessageTimeout"]
  File "config\__init__.pyc", line 1099, in __getitem__
KeyError: 'noMessageTimeout'


In previous versions it works fine. Is it a bug or is that key removed or moved somewhere else)

 

Thanks

 

Join {nvda-addons@nvda-addons.groups.io to automatically receive all group messages.