Hello again

Anyway, I have performed the basic review on the 2021.05. Here is the result:

Basic review:
- License and copyright: FAIL
- Documentation: PASS
- Security: PASS
- User experience: FAIL

Comments:
- Licence & Copyright are missing in the source code file (.py). Of course the license file is in the repo, but it is not included when you distribute the add-on.
- UX: The help message of the script says: 'Announce the version of the executable of the focused window or copy it to the clipboard if pressed twice'. But actually it does not only announces the version; it also announces the name of the application or of the OS for Windows applications (Explorer, Notepad, etc.). You may want to use the description done in the doc or in the manifest instead.

Extra comments: these suggestions are not required to pass the basic review, they are just personal advices:
- The script is in the 'Speech' category. However, NVDA has natively a script that does a different but quite similar job and which is in the 'Tools' category: 'Speaks the filename of the active application along with the name of the currently loaded appModule'. IMO, your script seems more related to the 'Tools' category than the 'Speech' one.
- The script doc speaks of a plug-in. But it is actually a complete add-on.
- Doc: You may want to use the latest style.css from add-on template, optimized for visually impoaired people.

I hope you get this message before making a new release. This way, you can already provide a release including the modifications.

Note: I will be on holiday from next thursday and will not be able to answer regularily to my messages. If I have not the time to review your modficiations, someone else can do it. The two blocking points are very easy to check.

Cheers,

Cyrille


 

De : "Patrick ZAJDA"
A : nvda-addons@nvda-addons.groups.io
Envoyé: mardi 27 Juillet 2021 16:44
Objet : Re: [nvda-addons] Say Product Name and Version #AddonReview
 

Hello Cyrille,

 

You can download this add-on from this link: https://github.com/Nardol/SayProductNameAndVersion/releases/download/v2021.05/sayProductNameAndVersion-2021.05.nvda-addon

 

Thanks.

 

Le 27/07/2021 à 16:37, Cyrille via groups.io a écrit :

Hello Patrick

Could you provide a download link?
I'll try to review it before I go on vacation (thursday).

Cyrille



 

De : "Patrick ZAJDA"
A : nvda-addons@nvda-addons.groups.io
Envoyé: mardi 27 Juillet 2021 15:12
Objet : [nvda-addons] Say Product Name and Version #AddonReview
 

Hello,

 

I wish to ask for Say Product Name and Version add-on to be included on the website, so could it be reviewed please?

 

Repository: https://github.com/Nardol/SayProductNameAndVersion/

 

Add-on description :

This plugin add a shortcut to announce product name and version of the foreground application, or copy these informations to the clipboard.
Author: Patrick Zajda
Shortcut: NVDA+Shift+V
Press it twice to copy product name and version to the clipboard.
 

Best regards,

--
Patrick ZAJDA

--
Patrick ZAJDA