Re: requesting review of the SPRITEs Table Navigation for Chrome addon
1 - After removing SPRITES and restarting NVDA the following informations were not removed from nvda.ini:
The last line was added by me before checking it was a boolean value...
2 - After installation, the firstUse error is still present.
But is slightly different... Nothing was wrote on nvda.ini!
3 - The SPRITEs initial screen with info about logging, for me, should have a Ok or Close button...
4 - Setting firstUse to True, the welcome screen is shown.
Is not changed firstUse parameter from True to False.
5 - The log folder and log file are created but they are not used, supposedelly due to the next error...
6 - Important NVDA log fragments refering to SPRITEsAfter changing to a Chrome window:
DEBUGWARNING - Python warning (11:13:43.369) - MainThread (5624):
Fragment refering the firstUse error:
error in appModule 'chrome'
7 - Regarding:
• Braille display and row commands announcement.
We changed the string to use the , character, and have spaces.
is not true. You have changed to use ' comma ' and it was not the intended...
The line 239 is:
rowCombo = ' comma '.join(mappedRowRange)
and should be:
rowCombo = ', '.join(mappedRowRange)
8 - • Supporting different keyboard layouts.
9 - • Retaining functionality of tab, alt-F4, etc.
If you have the following in the __init__.py:
it is not enough to avoid any problem with the SPRITEs commands scheme?
10 - • We were unclear about the comments related to braille
display keys working and the cell announcements being problematic.
The Braille displays can have keys to gave commands to the screen reader and they keep working as advised even with the SPRITEs loaded...
By instance, I am in a table and activate SPRITEs mode.
If I press Tab in the PC keyboard I will move to second line.
If I press a Braille display key to go to next line, it works as advised avoiding the SPRITEs disabling of other commands.
By now, it is all...
Às 01:33 de 09/06/2021, Venkatesh Potluri escreveu: